Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test default none nonnullable #435

Closed
wants to merge 2 commits into from
Closed

Fix test default none nonnullable #435

wants to merge 2 commits into from

Conversation

dkellner
Copy link
Contributor

see #427

Fix `test_{default,default_setter}_none_nonnullable`

Both tests called the wrong helper function.

Furthermore `_test_default_none_nonnullable` mimicked the behaviour of
`_test_default_existent`, now it actually tests what its name suggests.

cc @funkyfuture

@dkellner
Fix test_{default,default_setter}_none_nonnullable
076d843 
Both tests called the wrong helper function.

Furthermore `_test_default_none_nonnullable` mimicked the behaviour of
`_test_default_existent`, now it actually tests what its name suggests.
@dkellner
Refactor using mark.parametrize
d71dd94
@dkellner dkellner force-pushed the fix-test-default-none-nonnullable branch from f70dcf8 to d71dd94 Compare August 15, 2018 05:13
funkyfuture
funkyfuture approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@funkyfuture funkyfuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@funkyfuture funkyfuture added this to the 1.2.1 milestone Aug 15, 2018
nicolaiarocci added a commit that referenced this pull request Oct 20, 2018
@nicolaiarocci
Changelog for #435
46d01b0
@nicolaiarocci
Copy link
Member

rebased and merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funkyfuture funkyfuture funkyfuture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@dkellner @nicolaiarocci @funkyfuture